Commit Graph

15 Commits

Author SHA1 Message Date
saud-97 3e07100dc2 Fixes: incorrect sorting when chapter name contains hyphens '-' (#7161)
* Fixes: incorrect sorting when chapter name contains hyphens '-'

* Added a test case for hyphen in ChapterRecognitionTest.kt

* Removed chapter range test case since it will be replaced by chapterContainingHyphensCase
2022-05-23 17:17:29 -04:00
arkon 4d23f35b9d Throw out old unit tests
Considering we never run or update them, they're not providing any value right now.
Kept the chapter recognition tests and bumped to JUnit 5.
2022-04-24 16:16:05 -04:00
E3FxGaming fcd6fe5d8a Fix Cover sharing and saving (#5335)
* Fix Cover sharing and saving

The newly added manga cover sharing only worked with manga saved to the library (due to the implemented CoverCache only recording covers of library manga).
The changes made with this commit fixes that behaviour by implementing a fallback: the cover can now also be retrieved from the Coil memoryCache.

* Removal of coil MemoryKey usage

No longer uses the coil memory key, instead starts a new Coil request for the cover retrieval.

* Removed try-/catch-wrapper and added context-passing

useCoverAsBitmap lost its try-/catch-wrapper and doesn't call for the context anymore.
Instead shareCover and saveCover now pass their activity as context to useCoverAsBitmap.

* Added missing parameter description for useCoverAsBitmap
2021-07-18 13:17:31 -04:00
arkon 89619b7836 Drop support for Android 5.x 2021-04-27 09:29:05 -04:00
arkon f7a6cbe5e2 Revert "Drop support for Android 5.x"
This reverts commit 443024cebb. Guess I'll do this a bit later so scb can get another major update first.

April Fools or whatever.
2021-03-31 22:20:59 -04:00
arkon 443024cebb Drop support for Android 5.x
It's 5-6 years old, and only accounts for 2% of users in the Firebase analytics.
2021-03-30 23:15:17 -04:00
TacoTheDank 415df2357c JDK8, lint fixing (#2888)
* Use Kotlin JDK8

* Satisfy a ton of lints

* Run res/layout files (and manifest) through reformatter
2020-04-18 14:47:22 -04:00
arkon 124f0e7093 Minor dependency updates 2020-03-15 22:54:10 -04:00
arkon 043e3784e8 Run linter 2020-02-26 18:03:34 -05:00
arkon 47f5ea881f Reorganize other util files 2020-02-02 22:22:54 -05:00
arkon 51d454cded Run formatting on test package 2020-01-11 22:04:23 -05:00
Carlos 7f90ad7847 Fix chapter recognition regex and detail number (#1213)
* Update basic filter for sources that include space between numbers

Wasnts matching on  vol. 1 ch. 10 previously so mangadex last chapter was showing volume number.

* Don't show last chapter number when there are 0 chapters or chapters with no numbers.

This prevents one shots from showing with -1 as last chapter and instead just leaves it blank

* added else to be Unknown instead of blank

* removed empty line
added test case

* switched to null safe ?.

* Revert "switched to null safe ?."

This reverts commit 97a9300d1bedc8e01efb439c180eced8eaa1da5b.
undo

* switched to null safe ?.
2018-01-26 14:32:34 +01:00
Bram van de Kerkhof aefe7b176a Fixes case where manga name ends with s. (#919) 2017-07-31 20:04:14 +02:00
Bram van de Kerkhof 4f5518bdd8 Fixed wrong chapter recognition for S0 - Chapter 00 (#499) 2016-10-20 16:28:25 +02:00
len a475ecec4d Test package in Kotlin 2016-06-15 12:53:12 +02:00