Convert webview into an activity (#2470)

Based on https://github.com/Jays2Kings/tachiyomiJ2K/commit/65804ebb3aca0a79377167334ff842c0789440f3

app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoController.kt

@@ -40,6 +40,7 @@ import eu.kanade.tachiyomi.ui.catalogue.global_search.CatalogueSearchController
 import eu.kanade.tachiyomi.ui.library.ChangeMangaCategoriesDialog
 import eu.kanade.tachiyomi.ui.main.MainActivity
 import eu.kanade.tachiyomi.ui.manga.MangaController
+import eu.kanade.tachiyomi.ui.webview.WebViewActivity
 import eu.kanade.tachiyomi.util.openInBrowser
 import eu.kanade.tachiyomi.util.snack
 import eu.kanade.tachiyomi.util.toast
@@ -297,8 +298,9 @@ class MangaInfoController : NucleusController<MangaInfoPresenter>(),
             return
         }
 
-        parentController?.router?.pushController(MangaWebViewController(source.id, url)
-            .withFadeTransaction())
+        val activity = activity ?: return
+        val intent = WebViewActivity.newIntent(activity, source.id, url, presenter.manga.title)
+        startActivity(intent)
     }
 
     /**

app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaWebViewController.kt

@@ -1,94 +0,0 @@
-package eu.kanade.tachiyomi.ui.manga.info
-
-import android.os.Bundle
-import android.view.*
-import android.webkit.WebView
-import eu.kanade.tachiyomi.R
-import eu.kanade.tachiyomi.source.SourceManager
-import eu.kanade.tachiyomi.source.online.HttpSource
-import eu.kanade.tachiyomi.ui.base.controller.BaseController
-import eu.kanade.tachiyomi.util.WebViewClientCompat
-import uy.kohesive.injekt.injectLazy
-
-class MangaWebViewController(bundle: Bundle? = null) : BaseController(bundle) {
-
-    private val sourceManager by injectLazy<SourceManager>()
-
-    init {
-        setHasOptionsMenu(true)
-    }
-
-    constructor(sourceId: Long, url: String) : this(Bundle().apply {
-        putLong(SOURCE_KEY, sourceId)
-        putString(URL_KEY, url)
-    })
-
-    override fun inflateView(inflater: LayoutInflater, container: ViewGroup): View {
-        return inflater.inflate(R.layout.manga_info_web_controller, container, false)
-    }
-
-    override fun onViewCreated(view: View) {
-        super.onViewCreated(view)
-        val source = sourceManager.get(args.getLong(SOURCE_KEY)) as? HttpSource ?: return
-        val url = args.getString(URL_KEY) ?: return
-        val headers = source.headers.toMultimap().mapValues { it.value.getOrNull(0) ?: "" }
-
-        val web = view as WebView
-        web.webViewClient = object : WebViewClientCompat() {
-            override fun shouldOverrideUrlCompat(view: WebView, url: String): Boolean {
-                view.loadUrl(url)
-                return true
-            }
-        }
-        web.settings.javaScriptEnabled = true
-        web.settings.userAgentString = source.headers["User-Agent"]
-        web.loadUrl(url, headers)
-    }
-
-    override fun onCreateOptionsMenu(menu: Menu, inflater: MenuInflater) {
-        inflater.inflate(R.menu.web_view, menu)
-    }
-
-    override fun onPrepareOptionsMenu(menu: Menu) {
-        val web = view as WebView
-        menu.findItem(R.id.action_forward).isVisible = web.canGoForward()
-    }
-
-    override fun onOptionsItemSelected(item: MenuItem): Boolean {
-        when (item.itemId) {
-            R.id.action_forward -> {
-                val web = view as WebView
-                if (web.canGoForward()) web.goForward()
-            }
-            R.id.action_refresh -> {
-                val web = view as WebView
-                web.reload()
-            }
-            R.id.action_close -> router.popController(this)
-            else -> return super.onOptionsItemSelected(item)
-        }
-        return true
-    }
-
-    override fun handleBack(): Boolean {
-        val web = view as WebView
-        if (web.canGoBack()) {
-            web.goBack()
-            return true
-        }
-        return super.handleBack()
-    }
-
-    override fun onDestroyView(view: View) {
-        val web = view as WebView
-        web.stopLoading()
-        web.destroy()
-        super.onDestroyView(view)
-    }
-
-    private companion object {
-        const val SOURCE_KEY = "source_key"
-        const val URL_KEY = "url_key"
-    }
-
-}