Minor extension update cleanup, default to on

app/src/main/java/eu/kanade/tachiyomi/extension/ExtensionManager.kt

@@ -187,7 +187,7 @@ class ExtensionManager(
         if (changed) {
             installedExtensions = mutInstalledExtensions
         }
-        preferences.extensionUpdatesCount().set(installedExtensions.count { it.hasUpdate })
+        updatePendingUpdatesCount()
     }
 
     /**
@@ -318,12 +318,12 @@ class ExtensionManager(
 
         override fun onExtensionInstalled(extension: Extension.Installed) {
             registerNewExtension(extension.withUpdateCheck())
-            preferences.extensionUpdatesCount().set(installedExtensions.count { it.hasUpdate })
+            updatePendingUpdatesCount()
         }
 
         override fun onExtensionUpdated(extension: Extension.Installed) {
             registerUpdatedExtension(extension.withUpdateCheck())
-            preferences.extensionUpdatesCount().set(installedExtensions.count { it.hasUpdate })
+            updatePendingUpdatesCount()
         }
 
         override fun onExtensionUntrusted(extension: Extension.Untrusted) {
@@ -332,7 +332,7 @@ class ExtensionManager(
 
         override fun onPackageUninstalled(pkgName: String) {
             unregisterExtension(pkgName)
-            preferences.extensionUpdatesCount().set(installedExtensions.count { it.hasUpdate })
+            updatePendingUpdatesCount()
         }
     }
 
@@ -346,4 +346,8 @@ class ExtensionManager(
         }
         return this
     }
+
+    private fun updatePendingUpdatesCount() {
+        preferences.extensionUpdatesCount().set(installedExtensions.count { it.hasUpdate })
+    }
 }

app/src/main/java/eu/kanade/tachiyomi/extension/ExtensionUpdateJob.kt

@@ -31,36 +31,37 @@ class ExtensionUpdateJob(private val context: Context, workerParams: WorkerParam
         } catch (e: Exception) {
             return@coroutineScope Result.failure()
         }
+
         if (pendingUpdates.isNotEmpty()) {
-            val names = pendingUpdates.map { it.name }
-            NotificationManagerCompat.from(context).apply {
-                notify(Notifications.ID_UPDATES_TO_EXTS,
-                    context.notification(Notifications.CHANNEL_UPDATES_TO_EXTS) {
-                        setContentTitle(
-                            context.resources.getQuantityString(
-                                R.plurals.update_check_notification_ext_updates,
-                                names.size,
-                                names.size
-                            )
-                        )
-                        val extNames = names.joinToString(", ")
-                        setContentText(extNames)
-                        setStyle(NotificationCompat.BigTextStyle().bigText(extNames))
-                        setSmallIcon(R.drawable.ic_extension_24dp)
-                        setContentIntent(
-                            NotificationReceiver.openExtensionsPendingActivity(
-                                context
-                            )
-                        )
-                        setAutoCancel(true)
-                    })
-            }
+            createUpdateNotification(pendingUpdates.map { it.name })
         }
+
         Result.success()
     }
 
+    private fun createUpdateNotification(names: List<String>) {
+        NotificationManagerCompat.from(context).apply {
+            notify(Notifications.ID_UPDATES_TO_EXTS,
+                context.notification(Notifications.CHANNEL_UPDATES_TO_EXTS) {
+                    setContentTitle(
+                        context.resources.getQuantityString(
+                            R.plurals.update_check_notification_ext_updates,
+                            names.size,
+                            names.size
+                        )
+                    )
+                    val extNames = names.joinToString(", ")
+                    setContentText(extNames)
+                    setStyle(NotificationCompat.BigTextStyle().bigText(extNames))
+                    setSmallIcon(R.drawable.ic_extension_24dp)
+                    setContentIntent(NotificationReceiver.openExtensionsPendingActivity(context))
+                    setAutoCancel(true)
+                })
+        }
+    }
+
     companion object {
-        const val TAG = "ExtensionUpdate"
+        private const val TAG = "ExtensionUpdate"
 
         fun setupTask(context: Context, forceAutoUpdateJob: Boolean? = null) {
             val preferences = Injekt.get<PreferencesHelper>()

app/src/main/java/eu/kanade/tachiyomi/extension/api/ExtensionGithubApi.kt

@@ -7,12 +7,14 @@ import com.github.salomonbrys.kotson.int
 import com.github.salomonbrys.kotson.string
 import com.google.gson.Gson
 import com.google.gson.JsonArray
+import eu.kanade.tachiyomi.data.preference.PreferencesHelper
 import eu.kanade.tachiyomi.extension.model.Extension
 import eu.kanade.tachiyomi.extension.model.LoadResult
 import eu.kanade.tachiyomi.extension.util.ExtensionLoader
 import eu.kanade.tachiyomi.network.GET
 import eu.kanade.tachiyomi.network.NetworkHelper
 import eu.kanade.tachiyomi.network.await
+import java.util.Date
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.withContext
 import okhttp3.Response
@@ -21,6 +23,7 @@ import uy.kohesive.injekt.injectLazy
 internal class ExtensionGithubApi {
 
     private val network: NetworkHelper by injectLazy()
+    private val preferences: PreferencesHelper by injectLazy()
 
     private val gson: Gson by injectLazy()
 
@@ -33,23 +36,29 @@ internal class ExtensionGithubApi {
     }
 
     suspend fun checkForUpdates(context: Context): List<Extension.Installed> {
+        val call = GET(EXT_URL)
+
         return withContext(Dispatchers.IO) {
-            val call = GET(EXT_URL)
             val response = network.client.newCall(call).await()
 
+            preferences.lastExtCheck().set(Date().time)
+
             if (response.isSuccessful) {
                 val extensions = parseResponse(response)
-                val extensionsWithUpdate = mutableListOf<Extension.Installed>()
 
                 val installedExtensions = ExtensionLoader.loadExtensions(context)
                     .filterIsInstance<LoadResult.Success>()
                     .map { it.extension }
+
+                val extensionsWithUpdate = mutableListOf<Extension.Installed>()
                 for (installedExt in installedExtensions) {
                     val pkgName = installedExt.pkgName
                     val availableExt = extensions.find { it.pkgName == pkgName } ?: continue
 
                     val hasUpdate = availableExt.versionCode > installedExt.versionCode
-                    if (hasUpdate) extensionsWithUpdate.add(installedExt)
+                    if (hasUpdate) {
+                        extensionsWithUpdate.add(installedExt)
+                    }
                 }
 
                 extensionsWithUpdate