Use interfaces for database managers, create a source manager

2015-10-08 13:15:29 +02:00
parent 7e3d7cb4c4
commit 67a2e99cc1
13 changed files with 415 additions and 214 deletions
@@ -1,107 +1,28 @@
 package eu.kanade.mangafeed.data.managers;

-import com.pushtorefresh.storio.sqlite.StorIOSQLite;
 import com.pushtorefresh.storio.sqlite.operations.delete.DeleteResult;
 import com.pushtorefresh.storio.sqlite.operations.delete.DeleteResults;
-import com.pushtorefresh.storio.sqlite.operations.get.PreparedGetListOfObjects;
 import com.pushtorefresh.storio.sqlite.operations.put.PutResult;
 import com.pushtorefresh.storio.sqlite.operations.put.PutResults;
-import com.pushtorefresh.storio.sqlite.queries.Query;

 import java.util.List;

 import eu.kanade.mangafeed.data.models.Chapter;
 import eu.kanade.mangafeed.data.models.Manga;
-import eu.kanade.mangafeed.data.tables.ChaptersTable;
 import rx.Observable;

-public class ChapterManager extends BaseManager {
+public interface ChapterManager {

-    public ChapterManager(StorIOSQLite db) {
-        super(db);
-    }
+    Observable<List<Chapter>> getChapters(Manga manga);

-    private PreparedGetListOfObjects<Chapter> prepareGet(Manga manga) {
-        return db.get()
-                .listOfObjects(Chapter.class)
-                .withQuery(Query.builder()
-                        .table(ChaptersTable.TABLE)
-                        .where(ChaptersTable.COLUMN_MANGA_ID + "=?")
-                        .whereArgs(manga.id)
-                        .build())
-                .prepare();
-    }
+    Observable<PutResult> insertChapter(Chapter chapter);

-    public Observable<List<Chapter>> get(Manga manga) {
-        return prepareGet(manga).createObservable();
-    }
+    Observable<PutResults<Chapter>> insertChapters(List<Chapter> chapters);

-    public Observable<PutResult> insert(Chapter chapter) {
-        return db.put()
-                .object(chapter)
-                .prepare()
-                .createObservable();
-    }
+    Observable insertOrRemoveChapters(Manga manga, List<Chapter> chapters);

-    public Observable<PutResults<Chapter>> insert(List<Chapter> chapters) {
-        return db.put()
-                .objects(chapters)
-                .prepare()
-                .createObservable();
-    }
+    Observable<DeleteResult> deleteChapter(Chapter chapter);

-    // Add new chapters or delete if the source deletes them
-    public Observable insertOrRemove(Manga manga, List<Chapter> chapters) {
-        // I don't know a better approach
-        // TODO Fix this method
-        return Observable.create(subscriber -> {
-            List<Chapter> dbChapters = prepareGet(manga).executeAsBlocking();
+    Observable<DeleteResults<Chapter>> deleteChapters(List<Chapter> chapters);

-            Observable<List<Chapter>> newChaptersObs =
-                    Observable.from(chapters)
-                    .filter(c -> !dbChapters.contains(c))
-                    .toList();
-
-            Observable<List<Chapter>> deletedChaptersObs =
-                    Observable.from(dbChapters)
-                    .filter(c -> !chapters.contains(c))
-                    .toList();
-
-            Observable.zip(newChaptersObs, deletedChaptersObs,
-                    (newChapters, deletedChapters) -> {
-                        insert(newChapters).subscribe();
-                        delete(deletedChapters).subscribe();
-                        subscriber.onCompleted();
-                        return null;
-                    }).subscribe();
-        });
-
-    }
-
-    public void createDummyChapters() {
-        Chapter c;
-
-        for (int i = 1; i < 100; i++) {
-            c = new Chapter();
-            c.manga_id = 1L;
-            c.name = "Chapter " + i;
-            c.url = "http://example.com/1";
-            insert(c).subscribe();
-        }
-
-    }
-
-    public Observable<DeleteResults<Chapter>> delete(List<Chapter> chapters) {
-        return db.delete()
-                .objects(chapters)
-                .prepare()
-                .createObservable();
-    }
-
-    public Observable<DeleteResult> delete(Chapter chapter) {
-        return db.delete()
-                .object(chapter)
-                .prepare()
-                .createObservable();
-    }
 }
@@ -0,0 +1,101 @@
+package eu.kanade.mangafeed.data.managers;
+
+import com.pushtorefresh.storio.sqlite.StorIOSQLite;
+import com.pushtorefresh.storio.sqlite.operations.delete.DeleteResult;
+import com.pushtorefresh.storio.sqlite.operations.delete.DeleteResults;
+import com.pushtorefresh.storio.sqlite.operations.get.PreparedGetListOfObjects;
+import com.pushtorefresh.storio.sqlite.operations.put.PutResult;
+import com.pushtorefresh.storio.sqlite.operations.put.PutResults;
+import com.pushtorefresh.storio.sqlite.queries.Query;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import eu.kanade.mangafeed.data.models.Chapter;
+import eu.kanade.mangafeed.data.models.Manga;
+import eu.kanade.mangafeed.data.tables.ChaptersTable;
+import rx.Observable;
+
+public class ChapterManagerImpl extends BaseManager implements ChapterManager {
+
+    public ChapterManagerImpl(StorIOSQLite db) {
+        super(db);
+    }
+
+    private PreparedGetListOfObjects<Chapter> prepareGet(Manga manga) {
+        return db.get()
+                .listOfObjects(Chapter.class)
+                .withQuery(Query.builder()
+                        .table(ChaptersTable.TABLE)
+                        .where(ChaptersTable.COLUMN_MANGA_ID + "=?")
+                        .whereArgs(manga.id)
+                        .build())
+                .prepare();
+    }
+
+    @Override
+    public Observable<List<Chapter>> getChapters(Manga manga) {
+        return prepareGet(manga).createObservable();
+    }
+
+    @Override
+    public Observable<PutResult> insertChapter(Chapter chapter) {
+        return db.put()
+                .object(chapter)
+                .prepare()
+                .createObservable();
+    }
+
+    @Override
+    public Observable<PutResults<Chapter>> insertChapters(List<Chapter> chapters) {
+        return db.put()
+                .objects(chapters)
+                .prepare()
+                .createObservable();
+    }
+
+    // Add new chapters or delete if the source deletes them
+    @Override
+    public Observable insertOrRemoveChapters(Manga manga, List<Chapter> chapters) {
+        // I don't know a better approach
+        // TODO Fix this method
+        return Observable.create(subscriber -> {
+            List<Chapter> dbChapters = prepareGet(manga).executeAsBlocking();
+
+            Observable<List<Chapter>> newChaptersObs =
+                    Observable.from(chapters)
+                            .filter(c -> !dbChapters.contains(c))
+                            .toList();
+
+            Observable<List<Chapter>> deletedChaptersObs =
+                    Observable.from(dbChapters)
+                            .filter(c -> !chapters.contains(c))
+                            .toList();
+
+            Observable.zip(newChaptersObs, deletedChaptersObs,
+                    (newChapters, deletedChapters) -> {
+                        insertChapters(newChapters).subscribe();
+                        deleteChapters(deletedChapters).subscribe();
+                        subscriber.onCompleted();
+                        return null;
+                    }).subscribe();
+        });
+    }
+
+    @Override
+    public Observable<DeleteResult> deleteChapter(Chapter chapter) {
+        return db.delete()
+                .object(chapter)
+                .prepare()
+                .createObservable();
+    }
+
+    @Override
+    public Observable<DeleteResults<Chapter>> deleteChapters(List<Chapter> chapters) {
+        return db.delete()
+                .objects(chapters)
+                .prepare()
+                .createObservable();
+    }
+
+}
@@ -1,97 +1,27 @@
 package eu.kanade.mangafeed.data.managers;

-import com.pushtorefresh.storio.sqlite.StorIOSQLite;
 import com.pushtorefresh.storio.sqlite.operations.delete.DeleteResult;
 import com.pushtorefresh.storio.sqlite.operations.delete.DeleteResults;
 import com.pushtorefresh.storio.sqlite.operations.put.PutResult;
-import com.pushtorefresh.storio.sqlite.queries.Query;
-import com.pushtorefresh.storio.sqlite.queries.RawQuery;
+import com.pushtorefresh.storio.sqlite.operations.put.PutResults;

 import java.util.List;

 import eu.kanade.mangafeed.data.models.Manga;
-import eu.kanade.mangafeed.data.tables.ChaptersTable;
-import eu.kanade.mangafeed.data.tables.MangasTable;
 import rx.Observable;

-public class MangaManager extends BaseManager {
+public interface MangaManager {

-    public MangaManager(StorIOSQLite db) {
-        super(db);
-    }
+    Observable<List<Manga>> getMangas();

-    private final String mangasWithUnreadQuery = String.format(
-            "SELECT %1$s.*, COUNT(C.%4$s) AS %5$s FROM %1$s LEFT JOIN " +
-            "(SELECT %4$s FROM %2$s WHERE %6$s = 0) AS C ON %3$s = C.%4$s " +
-            "GROUP BY %3$s",
-            MangasTable.TABLE,
-            ChaptersTable.TABLE,
-            MangasTable.TABLE + "." + MangasTable.COLUMN_ID,
-            ChaptersTable.COLUMN_MANGA_ID,
-            MangasTable.COLUMN_UNREAD,
-            ChaptersTable.COLUMN_READ
-    );
+    Observable<List<Manga>> getMangasWithUnread();

-    public Observable<List<Manga>> get() {
-        return db.get()
-                .listOfObjects(Manga.class)
-                .withQuery(Query.builder()
-                        .table(MangasTable.TABLE)
-                        .build())
-                .prepare()
-                .createObservable();
-    }
+    Observable<PutResult> insertManga(Manga manga);

-    public Observable<List<Manga>> getWithUnread() {
-        return db.get()
-                .listOfObjects(Manga.class)
-                .withQuery(RawQuery.builder()
-                        .query(mangasWithUnreadQuery)
-                        .observesTables(MangasTable.TABLE, ChaptersTable.TABLE)
-                        .build())
-                .prepare()
-                .createObservable();
-    }
+    Observable<PutResults<Manga>> insertMangas(List<Manga> mangas);

-    public Observable<PutResult> insert(Manga manga) {
-        return db.put()
-                .object(manga)
-                .prepare()
-                .createObservable();
-    }
+    Observable<DeleteResult> deleteManga(Manga manga);

-    public void createDummyManga() {
-        insert(createDummyManga("One Piece")).subscribe();
-        insert(createDummyManga("Übel Blatt")).subscribe();
-        insert(createDummyManga("Berserk")).subscribe();
-        insert(createDummyManga("Horimiya")).subscribe();
-    }
-
-    private Manga createDummyManga(String title) {
-        Manga m = new Manga();
-        m.title = title;
-        m.url="http://example.com";
-        m.artist="Eiichiro Oda";
-        m.author="Eiichiro Oda";
-        m.description="...";
-        m.genre="Action, Drama";
-        m.status="Ongoing";
-        m.thumbnail_url="http://example.com/pic.png";
-        return m;
-    }
-
-    public Observable<DeleteResult> delete(Manga manga) {
-        return db.delete()
-                .object(manga)
-                .prepare()
-                .createObservable();
-    }
-
-    public Observable<DeleteResults<Manga>> delete(List<Manga> mangas) {
-        return db.delete()
-                .objects(mangas)
-                .prepare()
-                .createObservable();
-    }
+    Observable<DeleteResults<Manga>> deleteMangas(List<Manga> mangas);

 }
@@ -0,0 +1,85 @@
+package eu.kanade.mangafeed.data.managers;
+
+import com.pushtorefresh.storio.sqlite.StorIOSQLite;
+import com.pushtorefresh.storio.sqlite.operations.delete.DeleteResult;
+import com.pushtorefresh.storio.sqlite.operations.delete.DeleteResults;
+import com.pushtorefresh.storio.sqlite.operations.put.PutResult;
+import com.pushtorefresh.storio.sqlite.operations.put.PutResults;
+import com.pushtorefresh.storio.sqlite.queries.Query;
+import com.pushtorefresh.storio.sqlite.queries.RawQuery;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import eu.kanade.mangafeed.data.models.Manga;
+import eu.kanade.mangafeed.data.tables.ChaptersTable;
+import eu.kanade.mangafeed.data.tables.MangasTable;
+import rx.Observable;
+
+public class MangaManagerImpl extends BaseManager implements MangaManager {
+
+    public MangaManagerImpl(StorIOSQLite db) {
+        super(db);
+    }
+
+    private final String mangasWithUnreadQuery = String.format(
+            "SELECT %1$s.*, COUNT(C.%4$s) AS %5$s FROM %1$s LEFT JOIN " +
+            "(SELECT %4$s FROM %2$s WHERE %6$s = 0) AS C ON %3$s = C.%4$s " +
+            "GROUP BY %3$s",
+            MangasTable.TABLE,
+            ChaptersTable.TABLE,
+            MangasTable.TABLE + "." + MangasTable.COLUMN_ID,
+            ChaptersTable.COLUMN_MANGA_ID,
+            MangasTable.COLUMN_UNREAD,
+            ChaptersTable.COLUMN_READ
+    );
+
+    public Observable<List<Manga>> getMangas() {
+        return db.get()
+                .listOfObjects(Manga.class)
+                .withQuery(Query.builder()
+                        .table(MangasTable.TABLE)
+                        .build())
+                .prepare()
+                .createObservable();
+    }
+
+    public Observable<List<Manga>> getMangasWithUnread() {
+        return db.get()
+                .listOfObjects(Manga.class)
+                .withQuery(RawQuery.builder()
+                        .query(mangasWithUnreadQuery)
+                        .observesTables(MangasTable.TABLE, ChaptersTable.TABLE)
+                        .build())
+                .prepare()
+                .createObservable();
+    }
+
+    public Observable<PutResult> insertManga(Manga manga) {
+        return db.put()
+                .object(manga)
+                .prepare()
+                .createObservable();
+    }
+
+    public Observable<PutResults<Manga>> insertMangas(List<Manga> mangas) {
+        return db.put()
+                .objects(mangas)
+                .prepare()
+                .createObservable();
+    }
+
+    public Observable<DeleteResult> deleteManga(Manga manga) {
+        return db.delete()
+                .object(manga)
+                .prepare()
+                .createObservable();
+    }
+
+    public Observable<DeleteResults<Manga>> deleteMangas(List<Manga> mangas) {
+        return db.delete()
+                .objects(mangas)
+                .prepare()
+                .createObservable();
+    }
+}