JDK8, lint fixing (#2888)

* Use Kotlin JDK8

* Satisfy a ton of lints

* Run res/layout files (and manifest) through reformatter

app/src/main/java/eu/kanade/tachiyomi/ui/source/SourcePresenter.kt

@@ -87,7 +87,7 @@ class SourcePresenter(
                 sharedObs.take(1),
                 sharedObs.skip(1).delay(500, TimeUnit.MILLISECONDS, AndroidSchedulers.mainThread()))
                 .distinctUntilChanged()
-                .map { (sourceManager.get(it) as? CatalogueSource)?.let { SourceItem(it) } }
+                .map { item -> (sourceManager.get(item) as? CatalogueSource)?.let { SourceItem(it) } }
                 .subscribeLatestCache(SourceController::setLastUsedSource)
     }
 

app/src/main/java/eu/kanade/tachiyomi/ui/source/browse/BrowseSourcePresenter.kt

@@ -149,9 +149,9 @@ open class BrowseSourcePresenter(
         pagerSubscription?.let { remove(it) }
         pagerSubscription = pager.results()
                 .observeOn(Schedulers.io())
-                .map { it.first to it.second.map { networkToLocalManga(it, sourceId) } }
+                .map { pair -> pair.first to pair.second.map { networkToLocalManga(it, sourceId) } }
                 .doOnNext { initializeMangas(it.second) }
-                .map { it.first to it.second.map { SourceItem(it, catalogueAsList) } }
+                .map { pair -> pair.first to pair.second.map { SourceItem(it, catalogueAsList) } }
                 .observeOn(AndroidSchedulers.mainThread())
                 .subscribeReplay({ view, (page, mangas) ->
                     view.onAddPage(page, mangas)
@@ -292,17 +292,17 @@ open class BrowseSourcePresenter(
     }
 
     private fun FilterList.toItems(): List<IFlexible<*>> {
-        return mapNotNull {
-            when (it) {
-                is Filter.Header -> HeaderItem(it)
-                is Filter.Separator -> SeparatorItem(it)
-                is Filter.CheckBox -> CheckboxItem(it)
-                is Filter.TriState -> TriStateItem(it)
-                is Filter.Text -> TextItem(it)
-                is Filter.Select<*> -> SelectItem(it)
+        return mapNotNull { filter ->
+            when (filter) {
+                is Filter.Header -> HeaderItem(filter)
+                is Filter.Separator -> SeparatorItem(filter)
+                is Filter.CheckBox -> CheckboxItem(filter)
+                is Filter.TriState -> TriStateItem(filter)
+                is Filter.Text -> TextItem(filter)
+                is Filter.Select<*> -> SelectItem(filter)
                 is Filter.Group<*> -> {
-                    val group = GroupItem(it)
-                    val subItems = it.state.mapNotNull {
+                    val group = GroupItem(filter)
+                    val subItems = filter.state.mapNotNull {
                         when (it) {
                             is Filter.CheckBox -> CheckboxSectionItem(it)
                             is Filter.TriState -> TriStateSectionItem(it)
@@ -316,8 +316,8 @@ open class BrowseSourcePresenter(
                     group
                 }
                 is Filter.Sort -> {
-                    val group = SortGroup(it)
-                    val subItems = it.values.map {
+                    val group = SortGroup(filter)
+                    val subItems = filter.values.map {
                         SortItem(it, group)
                     }
                     group.subItems = subItems

app/src/main/java/eu/kanade/tachiyomi/ui/source/browse/ProgressItem.kt

@@ -43,6 +43,10 @@ class ProgressItem : AbstractFlexibleItem<ProgressItem.Holder>() {
         return this === other
     }
 
+    override fun hashCode(): Int {
+        return loadMore.hashCode()
+    }
+
     class Holder(view: View, adapter: FlexibleAdapter<*>) : FlexibleViewHolder(view, adapter) {
 
         val progressBar: ProgressBar = view.findViewById(R.id.progress_bar)

app/src/main/java/eu/kanade/tachiyomi/ui/source/global_search/GlobalSearchPresenter.kt

@@ -163,9 +163,9 @@ open class GlobalSearchPresenter(
                             .subscribeOn(Schedulers.io())
                             .onErrorReturn { MangasPage(emptyList(), false) } // Ignore timeouts or other exceptions
                             .map { it.mangas.take(10) } // Get at most 10 manga from search result.
-                            .map { it.map { networkToLocalManga(it, source.id) } } // Convert to local manga.
+                            .map { list -> list.map { networkToLocalManga(it, source.id) } } // Convert to local manga.
                             .doOnNext { fetchImage(it, source) } // Load manga covers.
-                            .map { createCatalogueSearchItem(source, it.map { GlobalSearchCardItem(it) }) }
+                            .map { list -> createCatalogueSearchItem(source, list.map { GlobalSearchCardItem(it) }) }
                 }, 5)
                 .observeOn(AndroidSchedulers.mainThread())
                 // Update matching source with the obtained results
@@ -198,9 +198,9 @@ open class GlobalSearchPresenter(
     private fun initializeFetchImageSubscription() {
         fetchImageSubscription?.unsubscribe()
         fetchImageSubscription = fetchImageSubject.observeOn(Schedulers.io())
-                .flatMap {
-                    val source = it.second
-                    Observable.from(it.first).filter { it.thumbnail_url == null && !it.initialized }
+                .flatMap { pair ->
+                    val source = pair.second
+                    Observable.from(pair.first).filter { it.thumbnail_url == null && !it.initialized }
                             .map { Pair(it, source) }
                             .concatMap { getMangaDetailsObservable(it.first, it.second) }
                             .map { Pair(source as CatalogueSource, it) }