JDK8, lint fixing (#2888)

* Use Kotlin JDK8

* Satisfy a ton of lints

* Run res/layout files (and manifest) through reformatter

app/src/main/java/eu/kanade/tachiyomi/ui/manga/chapter/ChaptersController.kt

@@ -306,13 +306,13 @@ class ChaptersController : NucleusController<ChaptersControllerBinding, Chapters
     override fun onItemClick(view: View?, position: Int): Boolean {
         val adapter = adapter ?: return false
         val item = adapter.getItem(position) ?: return false
-        if (actionMode != null && adapter.mode == SelectableAdapter.Mode.MULTI) {
+        return if (actionMode != null && adapter.mode == SelectableAdapter.Mode.MULTI) {
             lastClickPosition = position
             toggleSelection(position)
-            return true
+            true
         } else {
             openChapter(item.chapter)
-            return false
+            false
         }
     }
 

app/src/main/java/eu/kanade/tachiyomi/ui/manga/chapter/ChaptersPresenter.kt

@@ -67,8 +67,8 @@ class ChaptersPresenter(
         // Prepare the relay.
         chaptersRelay.flatMap { applyChapterFilters(it) }
                 .observeOn(AndroidSchedulers.mainThread())
-                .subscribeLatestCache(ChaptersController::onNextChapters,
-                        { _, error -> Timber.e(error) })
+                .subscribeLatestCache(ChaptersController::onNextChapters)
+                { _, error -> Timber.e(error) }
 
         // Add the subscription that retrieves the chapters from the database, keeps subscribed to
         // changes, and sends the list of chapters to the relay.

app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoController.kt

@@ -262,13 +262,11 @@ class MangaInfoController(private val fromSource: Boolean = false) :
                     .centerCrop()
                     .into(binding.mangaCover)
 
-            if (binding.backdrop != null) {
-                GlideApp.with(view.context)
-                        .load(manga)
-                        .diskCacheStrategy(DiskCacheStrategy.RESOURCE)
-                        .centerCrop()
-                        .into(binding.backdrop!!)
-            }
+            GlideApp.with(view.context)
+                    .load(manga)
+                    .diskCacheStrategy(DiskCacheStrategy.RESOURCE)
+                    .centerCrop()
+                    .into(binding.backdrop)
         }
 
         // Manga info section
@@ -618,8 +616,7 @@ class MangaInfoController(private val fromSource: Boolean = false) :
             return
         }
 
-        val previousController = router.backstack[router.backstackSize - 2].controller()
-        when (previousController) {
+        when (val previousController = router.backstack[router.backstackSize - 2].controller()) {
             is LibraryController -> {
                 router.handleBack()
                 previousController.search(query)

app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/SetTrackStatusDialog.kt

@@ -33,7 +33,7 @@ class SetTrackStatusDialog<T> : DialogController
     override fun onCreateDialog(savedViewState: Bundle?): Dialog {
         val item = item
         val statusList = item.service.getStatusList()
-        val statusString = statusList.mapNotNull { item.service.getStatus(it) }
+        val statusString = statusList.map { item.service.getStatus(it) }
         val selectedIndex = statusList.indexOf(item.track?.status)
 
         return MaterialDialog.Builder(activity!!)

app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackController.kt

@@ -90,7 +90,7 @@ class TrackController : NucleusController<TrackControllerBinding, TrackPresenter
     override fun onLogoClick(position: Int) {
         val track = adapter?.getItem(position)?.track ?: return
 
-        if (track.tracking_url.isNullOrBlank()) {
+        if (track.tracking_url.isBlank()) {
             activity?.toast(R.string.url_not_set)
         } else {
             activity?.startActivity(Intent(Intent.ACTION_VIEW, Uri.parse(track.tracking_url)))

app/src/main/java/eu/kanade/tachiyomi/ui/manga/track/TrackSearchAdapter.kt

@@ -54,7 +54,7 @@ class TrackSearchAdapter(context: Context) :
             view.track_search_title.text = track.title
             view.track_search_summary.text = track.summary
             GlideApp.with(view.context).clear(view.track_search_cover)
-            if (!track.cover_url.isNullOrEmpty()) {
+            if (!track.cover_url.isEmpty()) {
                 GlideApp.with(view.context)
                         .load(track.cover_url)
                         .diskCacheStrategy(DiskCacheStrategy.RESOURCE)
@@ -62,21 +62,21 @@ class TrackSearchAdapter(context: Context) :
                         .into(view.track_search_cover)
             }
 
-            if (track.publishing_status.isNullOrBlank()) {
+            if (track.publishing_status.isBlank()) {
                 view.track_search_status.gone()
                 view.track_search_status_result.gone()
             } else {
                 view.track_search_status_result.text = track.publishing_status.capitalize()
             }
 
-            if (track.publishing_type.isNullOrBlank()) {
+            if (track.publishing_type.isBlank()) {
                 view.track_search_type.gone()
                 view.track_search_type_result.gone()
             } else {
                 view.track_search_type_result.text = track.publishing_type.capitalize()
             }
 
-            if (track.start_date.isNullOrBlank()) {
+            if (track.start_date.isBlank()) {
                 view.track_search_start.gone()
                 view.track_search_start_result.gone()
             } else {