Library now showing favorite mangas

app/src/main/java/eu/kanade/mangafeed/ui/activity/MangaDetailActivity.java

@@ -10,7 +10,9 @@ import android.support.v4.app.FragmentManager;
 import android.support.v4.app.FragmentPagerAdapter;
 import android.support.v4.view.ViewPager;
 import android.support.v7.widget.Toolbar;
+import android.view.Menu;
 import android.view.MenuItem;
+import android.widget.Toast;
 
 import butterknife.Bind;
 import butterknife.ButterKnife;
@@ -32,6 +34,7 @@ public class MangaDetailActivity extends BaseRxActivity<MangaDetailPresenter> {
     private MangaDetailAdapter adapter;
     private long manga_id;
     private boolean is_online;
+    private MenuItem favoriteBtn;
 
     public final static String MANGA_ID = "manga_id";
     public final static String MANGA_ONLINE = "manga_online";
@@ -62,12 +65,23 @@ public class MangaDetailActivity extends BaseRxActivity<MangaDetailPresenter> {
             getPresenter().queryManga(manga_id);
     }
 
+    @Override
+    public boolean onCreateOptionsMenu(Menu menu) {
+        getMenuInflater().inflate(R.menu.manga, menu);
+        favoriteBtn = menu.findItem(R.id.action_favorite);
+        getPresenter().setFavoriteVisibility();
+        return true;
+    }
+
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         switch (item.getItemId()) {
             case android.R.id.home:
                 finish();
                 return true;
+            case R.id.action_favorite:
+                onFavoriteClick();
+                return true;
         }
         return super.onOptionsItemSelected(item);
     }
@@ -98,10 +112,22 @@ public class MangaDetailActivity extends BaseRxActivity<MangaDetailPresenter> {
         setToolbarTitle(manga.title);
     }
 
+    public void setFavoriteBtnVisible(boolean visible) {
+        if (favoriteBtn != null)
+            favoriteBtn.setVisible(visible);
+    }
+
     public boolean isOnlineManga() {
         return is_online;
     }
 
+    private void onFavoriteClick() {
+        if (getPresenter().addToFavorites()) {
+            Toast.makeText(this, getString(R.string.toast_added_favorites), Toast.LENGTH_SHORT)
+                .show();
+        }
+    }
+
     class MangaDetailAdapter extends FragmentPagerAdapter {
 
         final int PAGE_COUNT = 2;

app/src/main/java/eu/kanade/mangafeed/ui/dialog/LoginDialogPreference.java

@@ -101,6 +101,9 @@ public class LoginDialogPreference extends DialogPreference {
         if (requestSubscription != null)
             requestSubscription.unsubscribe();
 
+        if (username.getText().length() == 0 || password.getText().length() == 0)
+            return;
+
         loginBtn.setProgress(1);
 
         requestSubscription = source.login(username.getText().toString(),